Fix include_{xy} issue when auto bounds is off #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaofl
changed the title
joaofl
force-pushed
the
joao/fix-include-xy-issue-with-auto-bounds-off
branch
from
cdf9be2 to
f687518
Compare
emilk
approved these changes
Apr 3, 2025
emilk
added
enhancement
emilk
added a commit
that referenced
this pull request
Apr 7, 2025
* This broke in #74 The problem was caused by using `PlotUi::set_auto_bounds`. I don't fully understand it all. I really don't like this. The code is confusing and lacking of tests, but as usual, I don't have time to dig into it right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-open the following PR originally open by @aholtzma-am:
emilk/egui#4539 (comment)
Closes #25
I did not try the suggested approach (emilk/egui#4539 (comment)), as I would need some more in-depth understanding before risking breaking other stuff.
Maybe, with some support, I could try to implement that approach in a separate PR.