Update to Rust 1.84 and enable many clippy lints #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
added
the
include in changelog
Contributor
|
Isn't egui only on 1.84? |
Contributor
|
Why not jumping to 1.86 and rust edition 2024? |
bircni
suggested changes
May 5, 2025
Collaborator
Author
I dont have a strong opinion on the matter. I needed to upgrade to 1.85 due to some dependency we have. |
emilk
approved these changes
May 6, 2025
Contributor
|
Gonna open another pr for 1.86 sometime |
abey79
changed the title
Collaborator
Author
Actually, we decided to stick to 1.84 for now, to align with egui. I'm updating this PR to this effect. |
Collaborator
Author
|
Link checker error not relevant, and fixed in #108 |
michalsustr
pushed a commit
that referenced
this pull request
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update rust to 1.84 to align with egui, and add a bunch of lints copy/pasted from Rerun's repo