Add optional legend title #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
requested changes
Jun 16, 2025
Owner
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
Looks good, but the title should always be on top
| pub text_style: TextStyle, | ||
| pub background_alpha: f32, | ||
| pub position: Corner, | ||
| pub title: Option<String>, |
Owner
There was a problem hiding this comment.
This could use WidgetText instead for more customizability
Contributor
Author
There was a problem hiding this comment.
doesn't work as WidgetText does not implement serde - we could do this here too but i dont know if that is good
Contributor
Author
|
when we update to the newer egui main we can use PixelThreshold so these tests dont fail anymore |
# Conflicts: # demo/tests/snapshots/demos/Items.png # demo/tests/snapshots/demos/Lines.png # demo/tests/snapshots/demos/Markers.png # demo/tests/snapshots/light_mode.png # demo/tests/snapshots/scale_0.50.png # demo/tests/snapshots/scale_1.00.png # demo/tests/snapshots/scale_1.39.png # demo/tests/snapshots/scale_2.00.png
lucasmerlin
added
enhancement
michalsustr
pushed a commit
that referenced
this pull request
Nov 26, 2025
This pull request introduces enhancements to the `Legend` functionality
in the `egui_plot` library, updates the plot demos to include legend
titles, and modifies related tests and snapshots to reflect these
changes. The most significant changes include adding a `title` property
to the `Legend` struct, updating plot demos to utilize this new feature,
and adjusting test infrastructure and snapshots accordingly.
### Enhancements to `Legend` functionality:
*
[`egui_plot/src/legend.rs`](diffhunk://#diff-41de195c6ebce678a328dcb6d36642dcccd13eb73aa023e13590b61e2f74f1cfR49):
Added a `title` property to the `Legend` struct, with a default value of
`None`. Introduced a new `title` method to set the legend title and
updated the `LegendWidget` to display the title if it is set.
[[1]](diffhunk://#diff-41de195c6ebce678a328dcb6d36642dcccd13eb73aa023e13590b61e2f74f1cfR49)
[[2]](diffhunk://#diff-41de195c6ebce678a328dcb6d36642dcccd13eb73aa023e13590b61e2f74f1cfR64)
[[3]](diffhunk://#diff-41de195c6ebce678a328dcb6d36642dcccd13eb73aa023e13590b61e2f74f1cfR94-R100)
[[4]](diffhunk://#diff-41de195c6ebce678a328dcb6d36642dcccd13eb73aa023e13590b61e2f74f1cfR340-R342)
### Updates to plot demos:
*
[`demo/src/plot_demo.rs`](diffhunk://#diff-5a1025d5dd6c016d4b4017e33bb3322bd767ab0591195efa41a2a41da09efc9eL286-R286):
Updated the `Legend` configuration in `LineDemo`, `MarkerDemo`, and
`ItemsDemo` to include titles ("Lines", "Markers", and "Items",
respectively).
[[1]](diffhunk://#diff-5a1025d5dd6c016d4b4017e33bb3322bd767ab0591195efa41a2a41da09efc9eL286-R286)
[[2]](diffhunk://#diff-5a1025d5dd6c016d4b4017e33bb3322bd767ab0591195efa41a2a41da09efc9eL376-R376)
[[3]](diffhunk://#diff-5a1025d5dd6c016d4b4017e33bb3322bd767ab0591195efa41a2a41da09efc9eL764-R768)
* Closes <#98>
* [x] I have followed the instructions in the PR template
---------
Co-authored-by: lucasmerlin <hi@lucasmerlin.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the
Legendfunctionality in theegui_plotlibrary, updates the plot demos to include legend titles, and modifies related tests and snapshots to reflect these changes. The most significant changes include adding atitleproperty to theLegendstruct, updating plot demos to utilize this new feature, and adjusting test infrastructure and snapshots accordingly.Enhancements to
Legendfunctionality:egui_plot/src/legend.rs: Added atitleproperty to theLegendstruct, with a default value ofNone. Introduced a newtitlemethod to set the legend title and updated theLegendWidgetto display the title if it is set. [1] [2] [3] [4]Updates to plot demos:
demo/src/plot_demo.rs: Updated theLegendconfiguration inLineDemo,MarkerDemo, andItemsDemoto include titles ("Lines", "Markers", and "Items", respectively). [1] [2] [3]Closes Title (or label) for legend. #98
I have followed the instructions in the PR template