Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay call to get_current_texture (possible small performance win) #3914

Merged
merged 6 commits into from
Jan 29, 2024
Merged

Delay call to get_current_texture (possible small performance win) #3914

merged 6 commits into from
Jan 29, 2024

Conversation

emilk
Copy link
Owner

@emilk emilk commented Jan 29, 2024 •
edited
Loading

This should help slightly with CPU/GPU parallelism when vsync is on.

I also return the time spent on vsync, which can help users figure out how much CPU wall-time was used on non-vsync stuff

@Wumpf Wumpf self-requested a review January 29, 2024 15:38
Wumpf
Wumpf approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I believe this should make the "low latency" rendering mode a lot more viable

crates/egui-wgpu/src/winit.rs Outdated Show resolved Hide resolved
@emilk emilk mentioned this pull request Jan 29, 2024
Merged
@emilk emilk merged commit 21253d8 into master Jan 29, 2024
35 checks passed
@emilk emilk deleted the emilk/wgpu-postpone-get_current_texture branch January 29, 2024 17:06
@emilk emilk changed the title Postpone call to get_current_texture Delay call to get_current_texture (possible small performance win) Feb 5, 2024
@emilk emilk added the performance Lower CPU/GPU usage (optimize) label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
egui-wgpu performance Lower CPU/GPU usage (optimize)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @Wumpf