Code cleanup

crates/egui/src/containers/scroll_area.rs

@@ -449,9 +449,9 @@ impl ScrollArea {
             if content_response.dragged() {
                 for d in 0..2 {
                     if has_bar[d] {
-                        ui.input(|i| {
-                            state.offset[d] -= i.pointer.delta()[d];
-                            state.vel[d] = i.pointer.velocity()[d];
+                        ui.input(|input| {
+                            state.offset[d] -= input.pointer.delta()[d];
+                            state.vel[d] = input.pointer.velocity()[d];
                         });
                         state.scroll_stuck_to_end[d] = false;
                     } else {

crates/egui/src/painter.rs

@@ -104,7 +104,9 @@ impl Painter {
         &self.ctx
     }
 
-    /// Available fonts.
+    /// Read-only access to the shared [`Fonts`].
+    ///
+    /// See [`Context`] documentation for how locks work.
     #[inline(always)]
     pub fn fonts<R>(&self, reader: impl FnOnce(&Fonts) -> R) -> R {
         self.ctx.fonts(reader)

crates/egui/src/widgets/drag_value.rs

@@ -425,8 +425,8 @@ impl<'a> Widget for DragValue<'a> {
         #[cfg(feature = "accesskit")]
         {
             use accesskit::{Action, ActionData};
-            ui.input(|i| {
-                for request in i.accesskit_action_requests(id, Action::SetValue) {
+            ui.input(|input| {
+                for request in input.accesskit_action_requests(id, Action::SetValue) {
                     if let Some(ActionData::NumericValue(new_value)) = request.data {
                         value = new_value;
                     }

crates/egui/src/widgets/progress_bar.rs

@@ -99,7 +99,8 @@ impl Widget for ProgressBar {
 
             let (dark, bright) = (0.7, 1.0);
             let color_factor = if animate {
-                lerp(dark..=bright, ui.input(|i| i.time).cos().abs())
+                let time = ui.input(|i| i.time);
+                lerp(dark..=bright, time.cos().abs())
             } else {
                 bright
             };

crates/egui/src/widgets/slider.rs

@@ -562,18 +562,18 @@ impl<'a> Slider<'a> {
                 SliderOrientation::Vertical => (Key::ArrowUp, Key::ArrowDown),
             };
 
-            ui.input(|i| {
-                decrement += i.num_presses(dec_key);
-                increment += i.num_presses(inc_key);
+            ui.input(|input| {
+                decrement += input.num_presses(dec_key);
+                increment += input.num_presses(inc_key);
             });
         }
 
         #[cfg(feature = "accesskit")]
         {
             use accesskit::Action;
-            ui.input(|i| {
-                decrement += i.num_accesskit_action_requests(response.id, Action::Decrement);
-                increment += i.num_accesskit_action_requests(response.id, Action::Increment);
+            ui.input(|input| {
+                decrement += input.num_accesskit_action_requests(response.id, Action::Decrement);
+                increment += input.num_accesskit_action_requests(response.id, Action::Increment);
             });
         }
 
@@ -600,8 +600,8 @@ impl<'a> Slider<'a> {
         #[cfg(feature = "accesskit")]
         {
             use accesskit::{Action, ActionData};
-            ui.input(|i| {
-                for request in i.accesskit_action_requests(response.id, Action::SetValue) {
+            ui.input(|input| {
+                for request in input.accesskit_action_requests(response.id, Action::SetValue) {
                     if let Some(ActionData::NumericValue(new_value)) = request.data {
                         self.set_value(new_value);
                     }
@@ -693,10 +693,10 @@ impl<'a> Slider<'a> {
 
     fn value_ui(&mut self, ui: &mut Ui, position_range: RangeInclusive<f32>) -> Response {
         // If [`DragValue`] is controlled from the keyboard and `step` is defined, set speed to `step`
-        let change = ui.input(|i| {
-            i.num_presses(Key::ArrowUp) as i32 + i.num_presses(Key::ArrowRight) as i32
-                - i.num_presses(Key::ArrowDown) as i32
-                - i.num_presses(Key::ArrowLeft) as i32
+        let change = ui.input(|input| {
+            input.num_presses(Key::ArrowUp) as i32 + input.num_presses(Key::ArrowRight) as i32
+                - input.num_presses(Key::ArrowDown) as i32
+                - input.num_presses(Key::ArrowLeft) as i32
         });
 
         let any_change = change != 0;