Nat hole punch discv5.2 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make node address generic as node address is not standalone from discv5 crate
|
thanks Alex, appreciate it :) |
emhane
force-pushed
the
nat-hole-punch-discv5.2
branch
from
ae58ea0
to
f876023
Compare
emhane
force-pushed
the
nat-hole-punch-discv5.2
branch
2 times, most recently
from
7cdc44f
to
90b10f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic that must be implemented for the nat hole punching protocol. The motivation behind having this code in a separate crate to discv5, is to allow for applications to hack on parts of discv5, then import them instead of the original part into discv5, without needing to copy-paste code from the discv5 crate to implement the extension.