Tools refactor #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implement MCP connectors as self-contained executables
- no change to chibi itself(!)
* two example MCP connectors are included:
- github-mcp -- more extensive python example with guardrails
- fetch-mcp -- simple bash script mcp example (demonstrates the
concept)
* tools read parameters from env var instead of stdin
- current implementation does both, but stdin option will be removed
* the verbosity flag is passed on to tools
* tools are responsible for their own guardrails -- see github-mcp for
an example
* update web_search tool to use uv
* update all tools to read JSON input from env var
Remove stdin fallback for reading arguments.
emesal
added a commit
that referenced
this pull request
Jan 25, 2026
1. New Module: src/safe_io.rs Created a reusable module providing: - atomic_write_json() - Write JSON atomically (temp file + fsync + rename) - atomic_write() - Write bytes atomically - FileLock - RAII file locking wrapper using fs2 This establishes the foundation for Issue #15 (unified safe file operations). 2. Issue #4: Config Validation (partition.rs:132-172) Added minimum value guards to StorageConfig methods: - max_entries() → .max(1) - prevents infinite loops - max_tokens() → .max(1) - prevents infinite loops - bytes_per_token() → .max(1) - prevents divide-by-zero - max_age_seconds() → .max(60) - minimum 1 minute prevents excessive rotation 3. Issue #3: Atomic Manifest Writes (partition.rs:439-445) Replaced direct file write in save_manifest() with safe_io::atomic_write_json(). This prevents manifest corruption from crashes during write operations. 4. Issue #2: File Locking (partition.rs:362-368, 489-491, 577-578) Added file locking to partition write operations: - Added lock_path() helper returning .transcript.lock - append_entry() now acquires exclusive lock before writing - rotate() now acquires exclusive lock before rotating 5. Issue #1: Performance Caching (partition.rs, state/mod.rs) Made ActiveState public with Clone, added caching support: - PartitionManager::load_with_cached_state() - load with optional cached state - PartitionManager::active_state() - getter for caching - AppState.active_state_cache: RefCell<HashMap<String, ActiveState>> - per-context cache - Updated append_to_transcript() to use/update cache - Cache invalidation in clear_context(), clear_context_by_name(), finalize_compaction(), and destroy_context()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.