Conversation
Collaborator
Author
|
Blocker to wait until the next attrs version is out |
Scienfitz
requested changes
Jul 28, 2025
AVHopp
approved these changes
Jul 28, 2025
Collaborator
AVHopp
left a comment
There was a problem hiding this comment.
Approving since this is already blocked by @Scienfitz review
7f5e396 to
b663a13
Compare
deep_mapping
AdrianSosic
commented
Jul 29, 2025
b663a13 to
f1fd5f9
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes attrs typing workarounds that were previously needed due to upstream issues in the attrs library, now that these issues have been fixed in the new attrs version.
- Updates the attrs dependency requirement from >=24.1.0 to >=25.4.0
- Removes workaround lambda functions and imports that were needed for older attrs versions
- Simplifies validator syntax to use the now-supported list format
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Updates attrs dependency to version 25.4.0 to enable removal of workarounds |
| baybe/utils/metadata.py | Removes lambda workaround for value_validator in deep_mapping |
| baybe/parameters/substance.py | Removes and_ import and replaces validator syntax with list format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now fixed upstream in the new
attrsversion.