Home Assistant 2021.6 support #10
Conversation
Version core-2022.2.9 (>=core-2021.6) requires version and config_flow defined. https://developers.home-assistant.io/docs/creating_integration_manifest/
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| 🚧 In development, but you can copy `sensor.py` down to your HASS install: just copy-paste `sensor.py` into a file name the same inside your HASS `custom_components/bchydro` directory. Edit `bchydro_username` and `bchydro_password` to match your BCHydro account. | |||
|
|
|||
| ## This fork fixes an issue with the manifest | |||
|
|
|||
| core-2021.6 required some changes. Currently it is working with core-2022.2.9 | |||
There was a problem hiding this comment.
Will this comment be needed after this PR is merged?
| "domain": "bchydro", | ||
| "name": "BC Hydro", | ||
| "documentation": "https://github.com/emcniece/hass-bchydro", | ||
| "documentation": "https://github.com/sascha432/hass-bchydro", |
There was a problem hiding this comment.
This documentation link change is valid for the fork, but this pull request is merging it back into emcniece/hass-bchydro and as such the link probably shouldn't change.
Are you interested in maintainership? Maybe we could move this project to an organization instead of personal repositories.
There was a problem hiding this comment.
You should change that to your repo, wasn't sure if you are still active. I think it is a good idea that you look over any code changes, this is just the manifest I modified.
manifest.json
Outdated
| "requirements": [] | ||
| "requirements": [ | ||
| "flake8==4.0.1", | ||
| "black==22.1.0" |
There was a problem hiding this comment.
flake8 and black are dev requirements, not deploy requirements - this script doesn't need them in order to run normally. What does adding them here do? I can't recall if it's the dependencies or requirements that causes Home Assistant to download the packages when this integration gets installed.
If Home Assistant does install these requirements, I'd lean toward omitting them from the manifest. Are they needed here to support the new manifest?
There was a problem hiding this comment.
In this case, there is no requirements. Home assistant installs any missing requirements during startup.
Here is the updated file
{ "version": "0.1.0", "domain": "bchydro", "name": "BC Hydro", "documentation": "https://github.com/emcniece/hass-bchydro", "dependencies": [], "codeowners": [], "requirements": [], "iot_class": "cloud_polling", "config_flow": false }
|
I'm curious to hear about your 401 issue. It's possible that BCHydro has changed the login/auth process and it's causing our flow to fail. |
|
Hi,
I just checked my stats and saw that it had retrieved some data. Maybe there is a rate limit blocking too many calls?
Or maybe they have temporary issues since it was working fine for 2 weeks and probably years before. I think I tried it 1 or 2 years ago but never integrated it into home assistant.
Screenshot of the stats:
From: Eric McNiece ***@***.***>
Sent: Tuesday, 8 March 2022 11:15
To: emcniece/hass-bchydro ***@***.***>
Cc: sascha lammers ***@***.***>; Author ***@***.***>
Subject: Re: [emcniece/hass-bchydro] Home Assistant 2021.6 support (PR #10)
I'm curious to hear about your 401 issue. It's possible that BCHydro has changed the login/auth process and it's causing our flow to fail.
|
This fork fixes an issue with the manifest
core-2021.6 required some changes. Currently it is working with core-2022.2.9