Skip to content

ConfigException if the specified bucket doesn't exist #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

muga
Copy link
Contributor

@muga muga commented Nov 21, 2015

If the specified bucket doesn't exist, S3 input plugin should throw ConfigException because this error happens by user's wrong configuration. In the current implemention, AmazonS3Exception is directly thrown.

2015-11-21 04:33:54.283 +0000 [WARN] (main): The specified bucket does not exist (Service: Amazon S3; Status Code: 404; Error Code: NoSuchBucket; Request ID: 3BE58F8F886BD369)
com.amazonaws.services.s3.model.AmazonS3Exception: The specified bucket does not exist (Service: Amazon S3; Status Code: 404; Error Code: NoSuchBucket; Request ID: 3BE58F8F886BD369)
    at com.amazonaws.http.AmazonHttpClient.handleErrorResponse(AmazonHttpClient.java:1239) ~[aws-java-sdk-1.5.2.jar:na]
    at com.amazonaws.http.AmazonHttpClient.executeOneRequest(AmazonHttpClient.java:823) ~[aws-java-sdk-1.5.2.jar:na]
    at com.amazonaws.http.AmazonHttpClient.executeHelper(AmazonHttpClient.java:506) ~[aws-java-sdk-1.5.2.jar:na]
    at com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:318) ~[aws-java-sdk-1.5.2.jar:na]
    at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:3595) ~[aws-java-sdk-1.5.2.jar:na]
    at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:3548) ~[aws-java-sdk-1.5.2.jar:na]
    at com.amazonaws.services.s3.AmazonS3Client.listObjects(AmazonS3Client.java:647) ~[aws-java-sdk-1.5.2.jar:na]
    at org.embulk.input.s3.AbstractS3FileInputPlugin.listS3FilesByPrefix(AbstractS3FileInputPlugin.java:167) ~[na:na]
    at org.embulk.input.s3.AbstractS3FileInputPlugin.listFiles(AbstractS3FileInputPlugin.java:150) ~[na:na]
    at org.embulk.input.s3.AbstractS3FileInputPlugin.transaction(AbstractS3FileInputPlugin.java:83) ~[na:na]
    at org.embulk.spi.FileInputRunner.transaction(FileInputRunner.java:65) ~[embulk-core-0.7.7.jar:na]

@frsyuki
Copy link
Contributor

frsyuki commented Nov 23, 2015

I think this implementation is unnecessarily verbose. I created #21 instead.

@frsyuki frsyuki closed this Nov 23, 2015
@frsyuki
Copy link
Contributor

frsyuki commented Nov 23, 2015

#20 requires another permission by the way (ListBuckets against AWS account, in addition to ListObjects/GetObject against a bucket). So it breaks backward compatibility.

@dmikurube dmikurube deleted the throw_config_error_if_bucket_not_exist branch July 14, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants