Merge pull request #188 from embulk/private-static-logger

Declare a private static logger in each class
embulk · Jul 14, 2020 · 3d279a2 · 3d279a2
2 parents 737a5ca + 63f1242
commit 3d279a2
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 3 deletions.
diff --git a/embulk-input-jdbc/src/main/java/org/embulk/input/jdbc/AbstractJdbcInputPlugin.java b/embulk-input-jdbc/src/main/java/org/embulk/input/jdbc/AbstractJdbcInputPlugin.java
@@ -52,7 +52,7 @@
 public abstract class AbstractJdbcInputPlugin
         implements InputPlugin
 {
-    protected final Logger logger = LoggerFactory.getLogger(getClass());
+    private static final Logger logger = LoggerFactory.getLogger(AbstractJdbcInputPlugin.class);
 
     public interface PluginTask extends Task
     {

diff --git a/embulk-input-jdbc/src/main/java/org/embulk/input/jdbc/JdbcInputConnection.java b/embulk-input-jdbc/src/main/java/org/embulk/input/jdbc/JdbcInputConnection.java
@@ -31,7 +31,7 @@
 public class JdbcInputConnection
         implements AutoCloseable
 {
-    protected final Logger logger = LoggerFactory.getLogger(getClass());
+    private static final Logger logger = LoggerFactory.getLogger(JdbcInputConnection.class);
 
     protected final Connection connection;
     protected final String schemaName;

diff --git a/embulk-input-mysql/src/main/java/org/embulk/input/MySQLInputPlugin.java b/embulk-input-mysql/src/main/java/org/embulk/input/MySQLInputPlugin.java
@@ -18,10 +18,14 @@
 import org.embulk.input.mysql.MySQLInputConnection;
 import org.embulk.input.mysql.getter.MySQLColumnGetterFactory;
 import org.embulk.spi.PageBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class MySQLInputPlugin
         extends AbstractJdbcInputPlugin
 {
+    private static final Logger logger = LoggerFactory.getLogger(MySQLInputPlugin.class);
+
     public interface MySQLPluginTask
             extends PluginTask
     {

diff --git a/embulk-input-mysql/src/main/java/org/embulk/input/mysql/MySQLInputConnection.java b/embulk-input-mysql/src/main/java/org/embulk/input/mysql/MySQLInputConnection.java
@@ -11,10 +11,14 @@
 import org.embulk.input.jdbc.JdbcInputConnection;
 import org.embulk.input.jdbc.JdbcLiteral;
 import org.embulk.input.jdbc.getter.ColumnGetter;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class MySQLInputConnection
         extends JdbcInputConnection
 {
+    private static final Logger logger = LoggerFactory.getLogger(MySQLInputConnection.class);
+
     public MySQLInputConnection(Connection connection)
             throws SQLException
     {

diff --git a/...input-postgresql/src/main/java/org/embulk/input/postgresql/PostgreSQLInputConnection.java b/...input-postgresql/src/main/java/org/embulk/input/postgresql/PostgreSQLInputConnection.java
@@ -14,7 +14,7 @@
 public class PostgreSQLInputConnection
         extends JdbcInputConnection
 {
-    private final Logger logger = LoggerFactory.getLogger(PostgreSQLInputConnection.class);
+    private static final Logger logger = LoggerFactory.getLogger(PostgreSQLInputConnection.class);
 
     public PostgreSQLInputConnection(Connection connection, String schemaName)
             throws SQLException

diff --git a/embulk-input-sqlserver/src/main/java/org/embulk/input/SQLServerInputPlugin.java b/embulk-input-sqlserver/src/main/java/org/embulk/input/SQLServerInputPlugin.java
@@ -17,12 +17,15 @@
 
 import org.embulk.input.sqlserver.getter.SQLServerColumnGetterFactory;
 import org.embulk.spi.PageBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import static java.util.Locale.ENGLISH;
 
 public class SQLServerInputPlugin
     extends AbstractJdbcInputPlugin
 {
+    private static final Logger logger = LoggerFactory.getLogger(SQLServerInputPlugin.class);
     private static int DEFAULT_PORT = 1433;
 
     public interface SQLServerPluginTask