Fix check in dependencySatisfies
in monorepo
#1131
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across exact same issue described in #1051 while working on porting
ember-animated
to V2 addon and all scenarios for versions 3.20 and below failed.Note that I've ensured all
@embroider/*
packages are latest (via deps updates or resolutions).Situation is exactly what was described in #1051:
ember-animated
is a monorepo withdocs
app running on 3.28 and when running ember-try scenario for 3.20, this check in@embroider/util
returns true, as both@embroider/util
andember-source@4.1
are in the hoisted mainnode_modules
, while thetest-app
in question has its ownember-source@3.20
in its localnode_modules
.I'm not sure this is right way to fix the issue nor how to properly test it with current test harness setup:
using
appRoot
totally makes sense fordependencySatisfies
macro (as we need to rely on the host app deps) but may not be the right choice when we invokepackageCache.resolve
on this line.@ef4 would love your input on this.
cc @simonihmig as original reporter of #1051, not sure if issue still persists for you.