Skip to content

WarpDrive Package Unification #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 28, 2025
Merged

WarpDrive Package Unification #1075

merged 9 commits into from
Feb 28, 2025

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Feb 13, 2025

Propose WarpDrive Package Unification

Rendered

Summary

This pull request is proposing a new RFC.

To succeed, it will need to pass into the Exploring Stage, followed by the Accepted Stage.

A Proposed or Exploring RFC may also move to the Closed Stage if it is withdrawn by the author or if it is rejected by the Ember team. This requires an "FCP to Close" period.

An FCP is required before merging this PR to advance to Accepted.

Upon merging this PR, automation will open a draft PR for this RFC to move to the Ready for Released Stage.

Exploring Stage Description

This stage is entered when the Ember team believes the concept described in the RFC should be pursued, but the RFC may still need some more work, discussion, answers to open questions, and/or a champion before it can move to the next stage.

An RFC is moved into Exploring with consensus of the relevant teams. The relevant team expects to spend time helping to refine the proposal. The RFC remains a PR and will have an Exploring label applied.

An Exploring RFC that is successfully completed can move to Accepted with an FCP is required as in the existing process. It may also be moved to Closed with an FCP.

Accepted Stage Description

To move into the "accepted stage" the RFC must have complete prose and have successfully passed through an "FCP to Accept" period in which the community has weighed in and consensus has been achieved on the direction. The relevant teams believe that the proposal is well-specified and ready for implementation. The RFC has a champion within one of the relevant teams.

If there are unanswered questions, we have outlined them and expect that they will be answered before Ready for Release.

When the RFC is accepted, the PR will be merged, and automation will open a new PR to move the RFC to the Ready for Release stage. That PR should be used to track implementation progress and gain consensus to move to the next stage.

Checklist to move to Exploring

  • The team believes the concepts described in the RFC should be pursued.
  • The label S-Proposed is removed from the PR and the label S-Exploring is added.
  • The Ember team is willing to work on the proposal to get it to Accepted

Checklist to move to Accepted

  • This PR has had the Final Comment Period label has been added to start the FCP
  • The RFC is announced in #news-and-announcements in the Ember Discord.
  • The RFC has complete prose, is well-specified and ready for implementation.
    • All sections of the RFC are filled out.
    • Any unanswered questions are outlined and expected to be answered before Ready for Release.
    • "How we teach this?" is sufficiently filled out.
  • The RFC has a champion within one of the relevant teams.
  • The RFC has consensus after the FCP period.

@runspired runspired added T-ember-data RFCs that impact the ember-data library T-deprecation T-framework RFCs that impact the ember.js library T-learning T-steering T-ember-cli RFCs that impact the ember-cli library T-TypeScript labels Feb 13, 2025
@runspired runspired self-assigned this Feb 13, 2025
@github-actions github-actions bot added the S-Proposed In the Proposed Stage label Feb 13, 2025
@runspired runspired marked this pull request as ready for review February 14, 2025 06:20
@ef4
Copy link
Contributor

ef4 commented Feb 14, 2025

Notes from RFC review discussion:

  • overall seems good
  • what would be the inter-package dependency strategy? (This RFC certainly doesn't make that problem worse, it makes it better, but so long as there are multiple packages, how broadly do they support each other's versions and how practical is it to test that matrix? The lack of this problem is one point in favor of the Alternatives discussion about a single package.)

@ef4 ef4 added S-Exploring In the Exploring RFC Stage Final Comment Period and removed S-Proposed In the Proposed Stage labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final Comment Period S-Exploring In the Exploring RFC Stage T-deprecation T-ember-cli RFCs that impact the ember-cli library T-ember-data RFCs that impact the ember-data library T-framework RFCs that impact the ember.js library T-learning T-steering T-TypeScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants