This repository was archived by the owner on May 26, 2019. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 867
Change search provider to DocSearch #1188
Merged
homu
merged 1 commit into
emberjs:master
from
jeradg:change-search-provider-to-docsearch
Jan 28, 2016
Merged
Change search provider to DocSearch #1188
homu
merged 1 commit into
emberjs:master
from
jeradg:change-search-provider-to-docsearch
Jan 28, 2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Investigating the failing build. The CSS compiled fine locally. I'll see if a tweak will get it working. |
That should do it... |
Thanks for doing this. Ran into a few snags testing it on my end, aiming to do that later this week. |
👍 nice! |
@jeradg Just checked over it, nice work! Could you squash your commits here and we'll get this merged :-) |
1eac4ee
to
616d8b4
Compare
Thanks all! @acorncom: Squashed and good to go. |
…Search Removed Swiftype gem, scripts and styles. Added DocSearch scripts and styles. Changed default DocSearch colours to Ember colours. Fixed alignment problem with search input at small screen sizes. Added padding above version select at small screen sizes.
616d8b4
to
b9c6570
Compare
@homu r+ |
📌 Commit b9c6570 has been approved by |
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Jan 28, 2016
…corncom Change search provider to DocSearch This PR changes the Guides search provider from Swiftkey to DocSearch. See issues #1184 and #1183 for discussion. Functionality checked in Chrome and Firefox latest. ### Screenshots *Small width:*  *Large width:*  *Typo correction:* 
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Guides search provider from Swiftkey to DocSearch.
See issues #1184 and #1183 for discussion.
Functionality checked in Chrome and Firefox latest.
Screenshots
Small width:

Large width:

Typo correction:
