Skip to content
This repository was archived by the owner on May 26, 2019. It is now read-only.

Change search provider to DocSearch #1188

Merged
merged 1 commit into from
Jan 28, 2016

Conversation

jeradg
Copy link
Contributor

@jeradg jeradg commented Jan 22, 2016

This PR changes the Guides search provider from Swiftkey to DocSearch.

See issues #1184 and #1183 for discussion.

Functionality checked in Chrome and Firefox latest.

Screenshots

Small width:
docsearch-small-width

Large width:
docsearch-large

Typo correction:
docsearch-spellcheck

@jeradg
Copy link
Contributor Author

jeradg commented Jan 22, 2016

Investigating the failing build. The CSS compiled fine locally. I'll see if a tweak will get it working.

@jeradg
Copy link
Contributor Author

jeradg commented Jan 22, 2016

That should do it...

@acorncom
Copy link
Contributor

Thanks for doing this. Ran into a few snags testing it on my end, aiming to do that later this week.

@trek
Copy link
Member

trek commented Jan 26, 2016

👍 nice!

@acorncom
Copy link
Contributor

@jeradg Just checked over it, nice work! Could you squash your commits here and we'll get this merged :-)

@jeradg jeradg force-pushed the change-search-provider-to-docsearch branch from 1eac4ee to 616d8b4 Compare January 28, 2016 03:23
@jeradg
Copy link
Contributor Author

jeradg commented Jan 28, 2016

Thanks all!

@acorncom: Squashed and good to go.

…Search

Removed Swiftype gem, scripts and styles.

Added DocSearch scripts and styles.

Changed default DocSearch colours to Ember colours.

Fixed alignment problem with search input at small screen sizes.

Added padding above version select at small screen sizes.
@jeradg jeradg force-pushed the change-search-provider-to-docsearch branch from 616d8b4 to b9c6570 Compare January 28, 2016 03:30
@acorncom
Copy link
Contributor

@homu r+

@homu
Copy link
Contributor

homu commented Jan 28, 2016

📌 Commit b9c6570 has been approved by acorncom

@homu
Copy link
Contributor

homu commented Jan 28, 2016

⚡ Test exempted - status

@homu homu merged commit b9c6570 into emberjs:master Jan 28, 2016
homu added a commit that referenced this pull request Jan 28, 2016
…corncom

Change search provider to DocSearch

This PR changes the Guides search provider from Swiftkey to DocSearch.

See issues #1184 and #1183 for discussion.

Functionality checked in Chrome and Firefox latest.

### Screenshots

*Small width:*
![docsearch-small-width](https://cloud.githubusercontent.com/assets/1948799/12516424/5f8aa0d6-c0fb-11e5-9ffe-acdb56bd20fa.png)

*Large width:*
![docsearch-large](https://cloud.githubusercontent.com/assets/1948799/12516422/5f83255e-c0fb-11e5-8ea6-6cd96f8ce676.png)

*Typo correction:*
![docsearch-spellcheck](https://cloud.githubusercontent.com/assets/1948799/12516423/5f898ffc-c0fb-11e5-8dcf-8fe63b6c2bf7.png)
@jeradg jeradg mentioned this pull request Jan 28, 2016
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants