Skip to content

Conversation

@fwoeck
Copy link
Contributor

@fwoeck fwoeck commented Jan 14, 2014

This change will make

Ember.A([undefined, 2, 3]).any(function (o) { return true; })

return "true" instead of "false" (see issue #4139).

@trek
Copy link
Member

trek commented Jan 19, 2014

@fwoeck Travis might have bailed on this. Restarting.

@wagenet
Copy link
Member

wagenet commented Jan 21, 2014

@fwoeck This commit message should probably be tagged as [BUGFIX beta].

@fwoeck
Copy link
Contributor Author

fwoeck commented Jan 21, 2014

@wagenet sure - is it OK this time, or should I amend the commit?

@rwjblue
Copy link
Member

rwjblue commented Jan 21, 2014

@fwoeck - Please update it, if you don't mind. It makes things quite a bit easier when figuring out what to merge into the beta branch. Sorry for the troubles...

@fwoeck
Copy link
Contributor Author

fwoeck commented Jan 21, 2014

no prob, it's done..

wagenet added a commit that referenced this pull request Jan 21, 2014
Allow enumerable/any to match undefined as value (issue #4139)
@wagenet wagenet merged commit 68c9cdb into emberjs:master Jan 21, 2014
@stefanpenner
Copy link
Member

@wagenet did this also make it to beta?

@rwjblue
Copy link
Member

rwjblue commented Jan 21, 2014

@stefanpenner - It is not done yet, but it is tagged for it, and I'll pull it in tonight (I generally review commits once a day and pull them over).

@stefanpenner
Copy link
Member

ah ok

@stefanpenner
Copy link
Member

i have been merging my own into beta, is this bad? Would you prefer i don't?

@rwjblue
Copy link
Member

rwjblue commented Jan 21, 2014

@stefanpenner - Totally up to you. If you want to, feel free. If you'd rather not, I've got it.

My process is to just review the commit logs for beta and master, and cherry-pick the commits needed. Most of the time we are pretty good about the prefixes, but sometimes we forget, so just to make sure all is well for beta, I review the changes (doc only changes definitely go into beta for example) for each commit. The total time requirement is pretty short, but by reviewing I personally have a higher confidence that all is well the next time I ship a beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants