-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Allow enumerable/any to match undefined as value (issue #4139) #4144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@fwoeck Travis might have bailed on this. Restarting. |
|
@fwoeck This commit message should probably be tagged as |
|
@wagenet sure - is it OK this time, or should I amend the commit? |
|
@fwoeck - Please update it, if you don't mind. It makes things quite a bit easier when figuring out what to merge into the beta branch. Sorry for the troubles... |
|
no prob, it's done.. |
Allow enumerable/any to match undefined as value (issue #4139)
|
@wagenet did this also make it to beta? |
|
@stefanpenner - It is not done yet, but it is tagged for it, and I'll pull it in tonight (I generally review commits once a day and pull them over). |
|
ah ok |
|
i have been merging my own into beta, is this bad? Would you prefer i don't? |
|
@stefanpenner - Totally up to you. If you want to, feel free. If you'd rather not, I've got it. My process is to just review the commit logs for beta and master, and cherry-pick the commits needed. Most of the time we are pretty good about the prefixes, but sometimes we forget, so just to make sure all is well for beta, I review the changes (doc only changes definitely go into beta for example) for each commit. The total time requirement is pretty short, but by reviewing I personally have a higher confidence that all is well the next time I ship a beta. |
This change will make
return "true" instead of "false" (see issue #4139).