Skip to content

Add git diff violation checking after build output#21195

Draft
NullVoxPopuli wants to merge 2 commits intomainfrom
nvp/prevent-git-diffs-during-build
Draft

Add git diff violation checking after build output#21195
NullVoxPopuli wants to merge 2 commits intomainfrom
nvp/prevent-git-diffs-during-build

Conversation

@NullVoxPopuli
Copy link
Contributor

Uses: https://github.com/wyvox/action-no-git-diff

We keep having issues with the root package.json, and we need our git diffs to be reliable in PRs, so this action will block on uncommitted generated changes -- which should only be an issue until we stabilize the package.json generation (or other generated outputs)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

📊 Package size report   -0%↓

File Before (Size / Brotli) After (Size / Brotli)
Total (Includes all files) 17.1 MB / 3.2 MB -0%↓17.1 MB / 0%↑3.2 MB
Tarball size 3.8 MB -0%↓3.8 MB

🤖 This report was automatically generated by pkg-size-action

@kategengler
Copy link
Member

I'm afraid to add something like this. We've seen the renamed-modules in package.json jump around, which is why you added this, but I think this will end up blocking unrelated changes, for example where locally and committed it is correct but after running the build in CI it has changed, for whatever reason.

I'd prefer linting the list or a test of the list.

@NullVoxPopuli
Copy link
Contributor Author

for whatever reason

it's something we need to understand and stabilize tho.

as is, the list is already sorted, so it should be pretty stable.

the one thing that is known not stable is the presence of the template-compiler modules -- this is resolved via: #21129 and I'm happy to wait for that PR before pressing too hard on ensuring stability of the package.json

iirc, there is also a line-ending flip-flop that occurs in the root package.json as well 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants