[DOC] Fix @ember/controller module name in API docs for LTS 4.8#21106
Open
johanrd wants to merge 1 commit intoemberjs:lts-4-8from
Open
[DOC] Fix @ember/controller module name in API docs for LTS 4.8#21106johanrd wants to merge 1 commit intoemberjs:lts-4-8from
@ember/controller module name in API docs for LTS 4.8#21106johanrd wants to merge 1 commit intoemberjs:lts-4-8from
Conversation
Add missing `@` prefix to `@module` JSDoc tag so that the API docs correctly list `@ember/controller` under Packages for the 4.8 LTS release. Backport of emberjs#20346 which fixed this on main (landed in 4.12+). Resolves emberjs#20348 for the 4.8 LTS branch.
Member
|
Since we won't release 4.8, this would never go out. The place it needs to be changed is in https://github.com/ember-learn/ember-api-docs-data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #20348 for the 4.8 LTS branch.
Add missing
@prefix to@moduleJSDoc tag so that the API docs correctly list@ember/controllerunder Packages for the 4.8 LTS release. (does not fix 4.9–4.11, but that is ok, i guess?)Backport of #20346 which fixed this on main (landed in 4.12+).