Move node tests to smoke-tests and test against the ES Modules rather than the require/AMD stuff#21105
Closed
NullVoxPopuli wants to merge 4 commits intonvp/prod-build-2from
Closed
Move node tests to smoke-tests and test against the ES Modules rather than the require/AMD stuff#21105NullVoxPopuli wants to merge 4 commits intonvp/prod-build-2from
NullVoxPopuli wants to merge 4 commits intonvp/prod-build-2from
Conversation
Contributor
Estimated Asset SizesDiff --- main/out.txt 2026-02-17 19:37:18.000000000 +0000
+++ pr/./pr-22510687787/out.txt 2026-02-28 01:46:06.000000000 +0000
@@ -1,62 +1,62 @@
╔═══════╤═══════════╤═══════════╗
║ │ Min │ Gzip ║
╟───────┼───────────┼───────────╢
-║ Total │ 351.99 KB │ 203.84 KB ║
+║ Total │ 322.58 KB │ 195.33 KB ║
╚═══════╧═══════════╧═══════════╝
╔══════════════════════╤═══════════╤═══════════╗
║ @ember/* │ Min │ Gzip ║
╟──────────────────────┼───────────┼───────────╢
-║ Total │ 313.39 KB │ 181.91 KB ║
+║ Total │ 274.12 KB │ 166.79 KB ║
╟──────────────────────┼───────────┼───────────╢
-║ -internals │ 36.65 KB │ 26.22 KB ║
-║ application │ 13.23 KB │ 8.05 KB ║
-║ array │ 13.01 KB │ 7.46 KB ║
-║ canary-features │ 304 B │ 389 B ║
-║ component │ 2.05 KB │ 1.64 KB ║
-║ controller │ 1.96 KB │ 1.41 KB ║
-║ debug │ 11.69 KB │ 8.12 KB ║
+║ -internals │ 58.04 KB │ 36.64 KB ║
+║ application │ 16.62 KB │ 9.19 KB ║
+║ array │ 15.79 KB │ 8.82 KB ║
+║ canary-features │ 298 B │ 386 B ║
+║ component │ 2.21 KB │ 1.69 KB ║
+║ controller │ 1.96 KB │ 1.43 KB ║
+║ debug │ 17.08 KB │ 11.26 KB ║
║ deprecated-features │ 31 B │ 77 B ║
║ destroyable │ 561 B │ 383 B ║
║ enumerable │ 259 B │ 387 B ║
-║ helper │ 1.08 KB │ 811 B ║
-║ instrumentation │ 2.43 KB │ 1.79 KB ║
-║ modifier │ 1.22 KB │ 965 B ║
-║ object │ 35.94 KB │ 22.16 KB ║
+║ helper │ 1.18 KB │ 860 B ║
+║ instrumentation │ 2.47 KB │ 1.77 KB ║
+║ modifier │ 1.34 KB │ 1.01 KB ║
+║ object │ 55.48 KB │ 29.25 KB ║
║ owner │ 159 B │ 178 B ║
-║ renderer │ 630 B │ 487 B ║
-║ routing │ 59.3 KB │ 34.12 KB ║
-║ runloop │ 2.36 KB │ 1.5 KB ║
-║ service │ 1 KB │ 845 B ║
-║ template │ 654 B │ 541 B ║
-║ template-compilation │ 429 B │ 366 B ║
-║ template-compiler │ 123.08 KB │ 59.45 KB ║
-║ template-factory │ 370 B │ 374 B ║
+║ renderer │ 671 B │ 526 B ║
+║ routing │ 72.64 KB │ 40.63 KB ║
+║ runloop │ 2.99 KB │ 1.74 KB ║
+║ service │ 1 KB │ 851 B ║
+║ template │ 695 B │ 564 B ║
+║ template-compilation │ 616 B │ 481 B ║
+║ template-compiler │ 16.11 KB │ 13.76 KB ║
+║ template-factory │ 419 B │ 400 B ║
║ test │ 923 B │ 627 B ║
-║ utils │ 4.11 KB │ 3.6 KB ║
+║ utils │ 4.62 KB │ 3.87 KB ║
║ version │ 55 B │ 131 B ║
╚══════════════════════╧═══════════╧═══════════╝
╔═════════════════╤══════════╤══════════╗
║ @glimmer/* │ Min │ Gzip ║
╟─────────────────┼──────────┼──────────╢
-║ Total │ 38.6 KB │ 21.94 KB ║
+║ Total │ 48.46 KB │ 28.53 KB ║
╟─────────────────┼──────────┼──────────╢
-║ destroyable │ 2.77 KB │ 1.39 KB ║
-║ encoder │ 81 B │ 171 B ║
+║ destroyable │ 4.48 KB │ 2.27 KB ║
+║ encoder │ 718 B │ 756 B ║
║ env │ 38 B │ 87 B ║
-║ global-context │ 886 B │ 545 B ║
-║ manager │ 977 B │ 608 B ║
-║ node │ 175 B │ 260 B ║
-║ opcode-compiler │ 1.11 KB │ 894 B ║
+║ global-context │ 2.16 KB │ 1.21 KB ║
+║ manager │ 6.44 KB │ 3.15 KB ║
+║ node │ 1.1 KB │ 896 B ║
+║ opcode-compiler │ 1.11 KB │ 890 B ║
║ owner │ 159 B │ 202 B ║
-║ program │ 252 B │ 301 B ║
-║ reference │ 548 B │ 531 B ║
-║ runtime │ 10.32 KB │ 5.32 KB ║
-║ tracking │ 1.34 KB │ 1.16 KB ║
-║ util │ 1.94 KB │ 1.68 KB ║
-║ validator │ 15.75 KB │ 6.96 KB ║
-║ vm │ 495 B │ 569 B ║
+║ program │ 367 B │ 339 B ║
+║ reference │ 3.49 KB │ 2.36 KB ║
+║ runtime │ 1.56 KB │ 1.36 KB ║
+║ tracking │ 2.05 KB │ 1.76 KB ║
+║ util │ 1.94 KB │ 1.64 KB ║
+║ validator │ 20.57 KB │ 9.78 KB ║
+║ vm │ 495 B │ 575 B ║
║ wire-format │ 1.84 KB │ 1.35 KB ║
╚═════════════════╧══════════╧══════════╝
Details
|
10 tasks
NullVoxPopuli
force-pushed
the
nvp/move-node-tests-to-scenarios
branch
from
3216cbe to
0120927
Compare
NullVoxPopuli
force-pushed
the
nvp/move-node-tests-to-scenarios
branch
from
5e52b69 to
d909c46
Compare
NullVoxPopuli
force-pushed
the
nvp/move-node-tests-to-scenarios
branch
from
d909c46 to
0a4b9f2
Compare
NullVoxPopuli
force-pushed
the
nvp/prod-build-2
branch
from
24e2102 to
ae53da8
Compare
Contributor
Author
|
superseded by #21169 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the node tests
they're in a new location: https://github.com/emberjs/ember.js/actions/runs/22510687786/job/65219224690?pr=21105
Requires: