Support methods on classes without explicit binding / arrow functions#21080
Draft
NullVoxPopuli wants to merge 2 commits intomainfrom
Draft
Support methods on classes without explicit binding / arrow functions#21080NullVoxPopuli wants to merge 2 commits intomainfrom
NullVoxPopuli wants to merge 2 commits intomainfrom
Conversation
NullVoxPopuli
changed the title
Contributor
Estimated Asset SizesDiff --- main/out.txt 2026-02-10 19:32:04.000000000 +0000
+++ pr/./pr-21888866559/out.txt 2026-02-11 01:14:30.000000000 +0000
@@ -1,59 +1,59 @@
╔═══════╤═══════════╤═══════════╗
║ │ Min │ Gzip ║
╟───────┼───────────┼───────────╢
-║ Total │ 352.02 KB │ 203.77 KB ║
+║ Total │ 352.02 KB │ 203.97 KB ║
╚═══════╧═══════════╧═══════════╝
╔══════════════════════╤═══════════╤═══════════╗
║ @ember/* │ Min │ Gzip ║
╟──────────────────────┼───────────┼───────────╢
-║ Total │ 313.42 KB │ 181.95 KB ║
+║ Total │ 313.42 KB │ 182.06 KB ║
╟──────────────────────┼───────────┼───────────╢
-║ -internals │ 36.65 KB │ 26.23 KB ║
-║ application │ 13.23 KB │ 8.09 KB ║
-║ array │ 13.01 KB │ 7.46 KB ║
+║ -internals │ 36.65 KB │ 26.17 KB ║
+║ application │ 13.23 KB │ 7.92 KB ║
+║ array │ 13.01 KB │ 7.53 KB ║
║ canary-features │ 304 B │ 389 B ║
-║ component │ 2.05 KB │ 1.64 KB ║
-║ controller │ 1.96 KB │ 1.41 KB ║
-║ debug │ 11.69 KB │ 8.12 KB ║
+║ component │ 2.05 KB │ 1.65 KB ║
+║ controller │ 1.96 KB │ 1.46 KB ║
+║ debug │ 11.69 KB │ 8.18 KB ║
║ deprecated-features │ 31 B │ 77 B ║
║ destroyable │ 561 B │ 383 B ║
║ enumerable │ 259 B │ 387 B ║
-║ helper │ 1.08 KB │ 803 B ║
+║ helper │ 1.08 KB │ 808 B ║
║ instrumentation │ 2.43 KB │ 1.79 KB ║
-║ modifier │ 1.22 KB │ 966 B ║
-║ object │ 35.94 KB │ 22.16 KB ║
+║ modifier │ 1.22 KB │ 1008 B ║
+║ object │ 35.94 KB │ 22.11 KB ║
║ owner │ 159 B │ 178 B ║
-║ renderer │ 630 B │ 492 B ║
-║ routing │ 59.33 KB │ 34.13 KB ║
-║ runloop │ 2.36 KB │ 1.5 KB ║
-║ service │ 1 KB │ 845 B ║
-║ template │ 654 B │ 519 B ║
+║ renderer │ 630 B │ 496 B ║
+║ routing │ 59.33 KB │ 34.09 KB ║
+║ runloop │ 2.36 KB │ 1.42 KB ║
+║ service │ 1 KB │ 849 B ║
+║ template │ 654 B │ 525 B ║
║ template-compilation │ 429 B │ 366 B ║
-║ template-compiler │ 123.08 KB │ 59.45 KB ║
-║ template-factory │ 370 B │ 374 B ║
+║ template-compiler │ 123.08 KB │ 59.67 KB ║
+║ template-factory │ 370 B │ 380 B ║
║ test │ 923 B │ 627 B ║
-║ utils │ 4.11 KB │ 3.6 KB ║
+║ utils │ 4.11 KB │ 3.63 KB ║
║ version │ 55 B │ 131 B ║
╚══════════════════════╧═══════════╧═══════════╝
╔═════════════════╤══════════╤══════════╗
║ @glimmer/* │ Min │ Gzip ║
╟─────────────────┼──────────┼──────────╢
-║ Total │ 38.6 KB │ 21.82 KB ║
+║ Total │ 38.6 KB │ 21.91 KB ║
╟─────────────────┼──────────┼──────────╢
║ destroyable │ 2.77 KB │ 1.39 KB ║
║ encoder │ 81 B │ 171 B ║
║ env │ 38 B │ 87 B ║
║ global-context │ 886 B │ 545 B ║
-║ manager │ 977 B │ 608 B ║
-║ node │ 175 B │ 245 B ║
-║ opcode-compiler │ 1.11 KB │ 894 B ║
+║ manager │ 977 B │ 618 B ║
+║ node │ 175 B │ 250 B ║
+║ opcode-compiler │ 1.11 KB │ 920 B ║
║ owner │ 159 B │ 202 B ║
-║ program │ 252 B │ 301 B ║
-║ reference │ 548 B │ 531 B ║
-║ runtime │ 10.32 KB │ 5.22 KB ║
-║ tracking │ 1.34 KB │ 1.16 KB ║
+║ program │ 252 B │ 288 B ║
+║ reference │ 548 B │ 547 B ║
+║ runtime │ 10.32 KB │ 5.25 KB ║
+║ tracking │ 1.34 KB │ 1.19 KB ║
║ util │ 1.94 KB │ 1.68 KB ║
║ validator │ 15.75 KB │ 6.96 KB ║
║ vm │ 495 B │ 569 B ║Details
|
NullVoxPopuli
force-pushed
the
nvp/fix-the-issue-where-regular-class-methods-cant-be-used
branch
from
b4dabc9 to
67250c0
Compare
Contributor
📊 Package size report 0.06%↑
🤖 This report was automatically generated by pkg-size-action |
5 tasks
NullVoxPopuli
force-pushed
the
nvp/fix-the-issue-where-regular-class-methods-cant-be-used
branch
from
1447cbb to
67250c0
Compare
Fix Update smoke test to be very sure Fix Refactor createInvokableRef to use ReferenceImpl for improved clarity and maintainability Add VM_INVOKABLE_REFERENCE_OP and related functionality to support invokable references is this meaningful really? lint
NullVoxPopuli
force-pushed
the
nvp/fix-the-issue-where-regular-class-methods-cant-be-used
branch
from
67250c0 to
ccb280f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.