[BUGFIX beta] remove jQuery deprecation code from production builds #17555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Feb 3, 2019
Member
|
Thank you! |
Contributor
Author
|
Not sure what's failing the tests here for IE and Edge ("multiple calls to next share coalesce callbacks into same run loop"), but it seems unrelated!? |
Member
|
I doubt that the failure is related. I've restarted it. |
Contributor
Author
|
@rwjblue thanks! Green now! :) |
Member
|
This is marked 'Bugfix beta', the code it modified has a previous commit that isn't in beta #17525 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirmed by looking at
ember.min.jsthat the Proxy code is indeed stripped.Fixes #17550