Expose ability to detect serialization node. #16300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rondale-sc
changed the title
rwjblue
reviewed
Feb 28, 2018
packages/ember/lib/index.js
Outdated
| getChildViews: views.getChildViews | ||
| getChildViews: views.getChildViews, | ||
| isSerializationFirstNode: isSerializationFirstNode, | ||
| SERIALIZATION_FIRST_NODE_STRING: SERIALIZATION_FIRST_NODE_STRING |
Member
There was a problem hiding this comment.
I’d rather not export this string for now (we can always come back and do it later if needed)...
Member
|
Just published glimmer-vm 0.32.2 with the function exported, mind updating? |
This is dependent on this glimmer-vm PR to actually work glimmerjs/glimmer-vm#788. Which means we'll need to wait until it is merged/bumped and Ember itself updates to use the release with it in it before we can land this. The idea here is to insulate things that depend on the magic string we use to determine whether or not the DOM node we pass was produced by the serialization element builder. This needs to be exposed on the global to ensure we can use it in the ember-cli-fastboot vendor file so we can determine how to boot the app when it is loaded in the browser. To see where it'd be used in ember-cli-fastboot please see this PR with the in progress work: ember-fastboot/ember-cli-fastboot#580
rondale-sc
force-pushed
the
tack-serialization-first-node-util-to-ember-view-utils
branch
from
34e040f to
857b937
Compare
rondale-sc
force-pushed
the
tack-serialization-first-node-util-to-ember-view-utils
branch
from
857b937 to
86f1591
Compare
rwjblue
approved these changes
Mar 6, 2018
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dependent on this glimmer-vm PR to actually work glimmerjs/glimmer-vm#788. Which means we'll need to wait until it is merged/bumped and Ember itself updates to use the release with it in it before we can land this.
The idea here is to insulate things that depend on the magic string we use to determine whether or not the DOM node we pass was produced by the serialization element builder.
This needs to be exposed on the global to ensure we can use it in the ember-cli-fastboot vendor file so we can determine how to boot the app when it is loaded in the browser.
To see where it'd be used in ember-cli-fastboot please see this PR with the in progress work:
ember-fastboot/ember-cli-fastboot#580