Move computed property caches into a weak map #16222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Feb 8, 2018
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Looks great to me! We should do a macro benchmark to sanity check things here...
Member
|
For those following along, we are trying to remove usage of |
mmun
force-pushed
the
move-cp-cache-to-weakmap
branch
from
4dad3c4 to
7f3f387
Compare
Member
Author
|
Here are the results I got from benchmarking https://emberobserver.com/categories/components: Here are meta counters for loading the index page:
|
Member
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing our effort to make meta smaller...
FYI, the
cacheFor.{get,set,remove}have never been used in a public add-on so I'm remove them. We weren't even using them internally :)