Skip to content

Conversation

@locks
Copy link
Contributor

@locks locks commented Sep 2, 2017

@Serabe
Copy link
Member

Serabe commented Sep 3, 2017

@locks can you add the [DOC] tag to the title?

Restarted sauce labs.

@locks locks force-pushed the move-htmlsafe-ishtmlsafe branch from 9a2ce90 to 5dd87ea Compare September 3, 2017 20:18
@acorncom
Copy link
Contributor

acorncom commented Sep 8, 2017

@Serabe [DOC] tag to the commit (which looks to be done now) or the PR?

@Serabe
Copy link
Member

Serabe commented Sep 8, 2017

@acorncom usually both.

@acorncom acorncom changed the title Move htmlSafe and isHTMLSafe to Ember.Component in documentation [DOC RELEASE] Move htmlSafe and isHTMLSafe to Ember.Component in documentation Sep 8, 2017
@acorncom
Copy link
Contributor

acorncom commented Sep 8, 2017

@Serabe thanks, PR title updated

@alvincrespo
Copy link
Contributor

Curious. Why is the @for tag updated to Ember.Component instead of Ember.String. Not apparent to me.

@locks
Copy link
Contributor Author

locks commented Sep 10, 2017

@alvincrespo part of emberjs/rfcs#236. The RFC still needs some tweaks, which I'll submit post vacations :)

@alvincrespo
Copy link
Contributor

Awesome, have a safe and fun vacation - get off the internet 😄

@locks locks force-pushed the move-htmlsafe-ishtmlsafe branch from 5dd87ea to ccaefb0 Compare September 15, 2017 17:28
@locks locks changed the title [DOC RELEASE] Move htmlSafe and isHTMLSafe to Ember.Component in documentation [DOC RELEASE] Move htmlSafe and isHTMLSafe to Ember.Template in documentation Sep 29, 2017
@rwjblue
Copy link
Member

rwjblue commented Nov 8, 2017

Will need a rebase to accommodate the changes to the new API docs that @toddjordan did a few weeks ago.

@toddjordan
Copy link
Contributor

@locks this should rather be @for @ember/template, according to the rfc. Also, are we updating https://github.com/ember-cli/ember-rfc176-data/blob/master/mappings.json as well? Also what module/package is this landing in now? We'll need to add an @module

@locks
Copy link
Contributor Author

locks commented Nov 10, 2017

this should rather be @for @ember/template, according to the rfc.

Confirm!

Also, are we updating https://github.com/ember-cli/ember-rfc176-data/blob/master/mappings.json as well?

@Serabe is taking care of it :)

@Serabe Serabe force-pushed the move-htmlsafe-ishtmlsafe branch from ccaefb0 to a096a6a Compare December 11, 2017 23:47
@Serabe
Copy link
Member

Serabe commented Dec 11, 2017

Rebased

@Serabe
Copy link
Member

Serabe commented Dec 12, 2017

Restarted one job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants