[GLIMMER2] Optimize {{property}} PropertyReference #14041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
In my not completely scientific experiments, this accounts for over 10% improvement in initial render time. |
Contributor
|
@mmun I thought we had tests that allowed {{str.length}} |
Member
Author
|
@krisselden that crossed my mind too, but I am just mirroring the current behavior |
Member
Author
|
@krisselden while you are here, can you review 4ce0954 ? |
Member
Author
|
There seems to be additional wins associated with the latest commits, but my setup is too noisy to test that at the moment |
Contributor
|
@chancancode this is supported with the glimmer flag off https://ember-twiddle.com/cb89209f43d67d81fb74eaa59d442200?openFiles=templates.application.hbs%2C |
A quick survey in our app indicates ~77% of `PropertyReference` have a const parent. This is unsurprising, because most path lookup curlies are single-level (no dots in the path) lookup on the component directly. This means we can do less work and book-keeping in those cases (checking if the parent is a proxy on every `compute`, etc).
This avoids an extra shape transition when the component is updated.
We don’t need this anymore, see a447c48
This commit flips the responsibilities around – instead of making each reference do the work to track whether they are dealing with proxies, we can just make proxies themselves provide the right tag and do the book- keeping internally. With this change, `tagFor(proxy)` will return a tag that accounts for changes on the proxy itself as well as its content. This frees the rest of the system from worrying about that difference and removes a lot of runtime `isProxy` checks.
chancancode
force-pushed
the
optimize-property-reference
branch
2 times, most recently
from
10dd359 to
5d17ffe
Compare
chancancode
force-pushed
the
optimize-property-reference
branch
from
5d17ffe to
47511c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick survey in our app indicates ~77% of
PropertyReferencehave a const parent. This is unsurprising, because most path lookup curlies are single-level (no dots in the path) lookup on the component directly.This means we can do less work and book-keeping in those cases (checking if the parent is a proxy on every
compute, etc).