Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC release] Extend Route.paramsFor documentation #14034

Merged
merged 1 commit into from
Aug 26, 2016

Conversation

Serabe
Copy link
Member

@Serabe Serabe commented Aug 5, 2016

Improve documentation on Route.paramsFor as a result of today's meeting with the rest of the triage team.

Fixes #13771

cc @locks

Improve documentation on `Route.paramsFor`.

Fixes emberjs#13771
@Serabe Serabe changed the title [DOC release] Extend Route.paramsFor documentation [WIP] [DOC release] Extend Route.paramsFor documentation Aug 6, 2016
@Serabe
Copy link
Member Author

Serabe commented Aug 6, 2016

Forgot the WIP tag.

@pixelhandler pixelhandler changed the title [WIP] [DOC release] Extend Route.paramsFor documentation [DOC release] Extend Route.paramsFor documentation Aug 26, 2016
@pixelhandler
Copy link
Contributor

@emberjs/issues-team I think this looks good, the code examples makes it very clear that paramsFor are used with an ancestor route.

I am curious if Route.paramsFor also just works for any visited route, regardless of ancestry.

@locks locks merged commit fa82fe7 into emberjs:master Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants