-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[GLIMMER] Ensure the view registry is propagated. #13852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4bd494c to
5c107eb
Compare
|
should not be injected to every component, only the renderer and eventdispatcher need this. |
|
@krisselden - Sounds good. Will update. |
|
The renderer can register a view and the event dispatcher looks it up. Putting _viewRegistry on every component then dereferencing it up via every component is crappy. |
|
@krisselden - Components (in HTMLBars) currently have a |
|
the dom state should call register on the renderer, I don't think the fallback registry is important. I think it is cruft from when views may or may not have had an env and/or Ember.View.views |
53bb9b6 to
3b4f1dd
Compare
|
@krisselden - OK, updated to avoid threading the view registry around, and instead rely on the renderer to do the work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this test, since it is asserting a thing that is actually not valid (we do not want a _viewRegistry set on view/component instances at all).
ac8b47e to
2a233df
Compare
* Remove usage of `Ember.View.views`. This has not been exposed since 1.x. * Use the renderer to update view registry.
|
@chadhietala only in the sense that the test has been removed. |
component's all get the-view-registry:maininjected.Ember.View.viewsas the fallback registry, with a custom fallback registry that is only used when views/components are instantiated outside of the DI system.