View cruft removal. #13757
Merged
View cruft removal. #13757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The `.controller` and `.context` support was only present to support the legacy view and controller addons. That support only lasted through 2.6, and can be removed. * The `nearestChildOf` and `nearestInstanceOf` deprecations were added well before 2.0 (I have traced them back to at least 1.11), and they were private methods (documented as private since at least 1.12). When the `until` versions were added (to support the ember-debug-handlers feature) these were accidentally defaulted to 3.0.0.
* Remove `Ember.A` usage for `this.childViews` (this was left over from container view support). * Remove `this.childViews.slice` (also left over from container view). * Re-unified glimmer fork of the mixin.
These tests were ported to the newer INUR style test setup, and can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controllerin component/views.Ember.Ausage forthis.childViews(this was left over fromcontainer view support).
this.childViews.slice(also left over from container view).createChildView..controllerand.contextsupport was only present to supportthe legacy view and controller addons. That support only lasted
through 2.6, and can be removed.
nearestChildOfandnearestInstanceOfdeprecations were addedwell before 2.0 (I have traced them back to at least 1.11), and they
were private methods (documented as private since at least 1.12). When
the
untilversions were added (to support the ember-debug-handlersfeature) these were accidentally defaulted to 3.0.0.
viewNamesupport (used by legacy addons).