Skip to content

Conversation

@chadhietala
Copy link
Contributor

@chadhietala chadhietala commented Jun 22, 2016

/cc @rwjblue

@chadhietala chadhietala changed the title [Glimmer2] Move renderNode refs in view_support [WIP][Glimmer2] Move renderNode refs in view_support Jun 22, 2016
@rwjblue
Copy link
Member

rwjblue commented Jun 22, 2016

Seems good, but we should include at least an empty function in the glimmer component case (because Ember.TextSupport calls this.readDOMAttr() and it is a public API). It may be possible to add an implementation that reads from the element directly (as a first step). This will not "fix" the cursor position issues that plagued early Ember 1.13 work, but it should fix many other tests...

@chadhietala chadhietala force-pushed the move-render-node-things branch from b8b85dc to d2c1f99 Compare June 22, 2016 18:44
@chadhietala
Copy link
Contributor Author

@rwjblue This doesn't fix a bunch of tests because a lot of the tests depend on sendAction at this point which we need figure out in #13532.

@rwjblue
Copy link
Member

rwjblue commented Jun 22, 2016

Gotcha

@rwjblue rwjblue merged commit af590e3 into emberjs:master Jun 22, 2016
@chadhietala chadhietala deleted the move-render-node-things branch June 23, 2016 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants