Skip to content

Conversation

@tricknotes
Copy link
Member

This function became unnecessary with the followings:

I think we can remove this function due to un-exported.
If are there some fears, should it be shown deprecation warning?

@rwjblue
Copy link
Member

rwjblue commented Jun 21, 2016

I wondered if we needed _replace also, but it looks like the _replace function is still being used in ember-runtime/system/native_array.

Maybe we should just drop the underscore, and make it the default export in this file?

This old function `replace` became unnecessary with the followings:
* Ember.ArrayController: 9899dff
* Ember.Select: 4b5b972
@tricknotes tricknotes changed the title [BUGFIX beta] Remove unreferenced function ember-metal/replace [BUGFIX beta] Remove unreferenced function from ember-metal/replace Jun 21, 2016
@tricknotes tricknotes force-pushed the remove-ember-metal-replace branch from 3bfcb82 to 879a174 Compare June 21, 2016 13:39
@tricknotes
Copy link
Member Author

Completely agreed 👍
I updated my commit.

@rwjblue rwjblue merged commit ece9045 into emberjs:master Jun 21, 2016
@rwjblue
Copy link
Member

rwjblue commented Jun 21, 2016

Thanks again!

@tricknotes tricknotes deleted the remove-ember-metal-replace branch June 21, 2016 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants