[GLIMMER2] Closure actions + tests #13491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
I don't think you need to check the node.type anymore. traverse does that for you already.
zackthehuman
force-pushed
the
closure-actions-glimmer
branch
2 times, most recently
from
e2c420c to
b14c1f9
Compare
Contributor
|
☔ The latest upstream changes (presumably #13500) made this pull request unmergeable. Please resolve the merge conflicts. |
zackthehuman
force-pushed
the
closure-actions-glimmer
branch
from
b14c1f9 to
cbb2c37
Compare
zackthehuman
force-pushed
the
closure-actions-glimmer
branch
from
cbb2c37 to
356f737
Compare
toddjordan
pushed a commit
to toddjordan/ember.js
that referenced
this pull request
Sep 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements closure actions for Glimmer2. There are a few things that are unresolved:
Generate a label for the action (streams had labels, references don't?)Supportmut(there is nomutin Glimmer yet)SupportINVOKEables. Not sure what this is or how it's used, so I left it out.