Skip to content

Conversation

@danmcclain
Copy link
Contributor

No description provided.

@stefanpenner
Copy link
Member

stefanpenner commented Apr 20, 2016

Should we introduce fastboot mentions in ember API docs? Doesn't seem quite correct, we dont leave liquid fire or similar mentions in core API docs. Is there something more "neutral" that can be said?

@rwjblue
Copy link
Member

rwjblue commented Apr 20, 2016

Ember supports the primary feature that drives fastboot (the visit API) directly. I think the key isn't about fastboot or visit though, I believe it is all based on a hasDOM check. If we can confirm that, then we can mention that instead of fastboot.

@stefanpenner
Copy link
Member

@rwjblue ya, something not coupled to fast-boot. maybe some common vernacular they could both share?

cc @tomdale

@tomdale
Copy link
Member

tomdale commented May 4, 2016

This is a little tricky because it's weird to mention an addon in the Ember docs, but in practice people may end up going to the Ember docs to learn about which hooks are invoked or not in FastBoot, and I don't want to put ideology ahead of pragmatism.

I think hasDOM is the right way to think about it, but it's not something end users will likely be thinking of. Maybe we can say something as simple "Not invoked in Node.js environments"?

@homu
Copy link
Contributor

homu commented May 13, 2016

☔ The latest upstream changes (presumably #13500) made this pull request unmergeable. Please resolve the merge conflicts.

@pixelhandler
Copy link
Contributor

@tomdale cc @danmcclain I think it would be better to document how FastBoot utilizes the component hooks in the FastBoot docs instead of in the Ember docs.

@tomdale
Copy link
Member

tomdale commented Nov 19, 2016

@pixelhandler Keep in mind that the ability to run Ember apps in Node comes from the Ember framework itself, not FastBoot, via the visit() API. There will likely be other ways to run Ember apps in the future where these hooks don't get invoked.

@locks locks self-assigned this Apr 21, 2017
@locks
Copy link
Contributor

locks commented Jun 28, 2017

We'll likely move these efforts to emberjs/guides#1982.

@locks locks closed this Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants