[Glimmer2] Closure component test migration #13214
Conversation
Serabe
force-pushed
the
feature/glimmer-2-closure-component-test-migration
branch
from
792a5a5 to
24c3d49
Compare
Serabe
force-pushed
the
feature/glimmer-2-closure-component-test-migration
branch
2 times, most recently
from
c84e075 to
c6d3b77
Compare
Serabe
changed the title
Serabe
force-pushed
the
feature/glimmer-2-closure-component-test-migration
branch
from
c6d3b77 to
b997672
Compare
|
@chancancode I think these are finished. There are a couple of tests skipped and some parts of other commented because they are related to #13158 |
There was a problem hiding this comment.
Does this work with @htmlbars?
There was a problem hiding this comment.
No, because of the issue with updating positional parameters with the component helper.
Serabe
force-pushed
the
feature/glimmer-2-closure-component-test-migration
branch
from
b997672 to
924759e
Compare
|
@chadhietala thank you so much for reviewing this! I addressed most of the issues, leaving only the jQuery one (commented here) and the skipped tests (commented here). Thank you one more time! |
There was a problem hiding this comment.
Seems to be lost in the migration.
|
@Serabe Looks like there was only one missing test. Can you please update all of the R steps so that we actually do the replacement. See my comment here #13214 (diff) and #13325 for details. |
Serabe
force-pushed
the
feature/glimmer-2-closure-component-test-migration
branch
from
924759e to
b7457d4
Compare
|
@chadhietala thank you so much again for taking time to review this. I've just uploaded the changes. Let me know if I forgot something or if I can do anything to improve this, let me know! Thank you! |
Migrate tests for closure component.
Serabe
force-pushed
the
feature/glimmer-2-closure-component-test-migration
branch
from
b7457d4 to
4b3a838
Compare
|
Rebased master. I had not done so in a while :$ |
|
@Serabe Awesome! I think this one is good to go. 🎉 💥 🎉 . |
|
Thank you @Serabe! |
3 participants
Migrate tests for closure component.