[Glimmer2] Port {{yield}} test to ember-glimmer.

[kiwiupover]

No description provided.

[kiwiupover]

I have a bit more work to do here.

[kiwiupover]

Replace by line #28

[chancancode]

✔️ should yield to block, when the yield is embedded in a each helper

[kiwiupover]

Replaced by #7

[chancancode]

✔️ can yield to block

[kiwiupover]

Replaced by #196

[kiwiupover]

@chancancode this is ready for you, mate.

[kiwiupover]

It seems to me that parentView is not yet implemented yet in glimmer2?

I could be totally wrong and I just need to figure out what the hell I'm doing.

[wycats]

It should be implemented. There may be bugs, though.

[wycats]

"virtual view" is no longer terminology in Ember. yield should not introduce a view perhaps?

[wycats]

s/outer context/original context/

[wycats]

Meta-comment: if you decided not to do the full INUR for a given test, can you write a comment in the test explaining why?

[kiwiupover]

Thanks for the review @wycats I will get these addressed.

[krisselden]

can you drop the divs and just do just assert HelloHelloHelloHelloHello?

[kiwiupover]

I pulled a lot of the DOM out of the test cases. I'm totally willing to put that back if we feel that would be valuable. @krisselden

[chadhietala]

Might want to do something like

this.assertComponentElement(this.nthChild(0).firstChild, { tagName: 'div', attrs: {class: 'yielding' } });

[kiwiupover]

@chadhietala the nthChild method seems to be more of a nthSibling method.

The DOM that this test produces is

<div id='ember342'>
   <div id='ember344'>
      <div class='yielding'></div>
   </div>
</div>

Hence the your assertion suggestion will not work.

Is there a need for a help to asset deep into a DOM tree?

I have updated to the test to be simpler. Here

[chadhietala]

Just that one nit, otherwise LGTM.

[kiwiupover]

@wycats @chadhietala This is ready for review.

@chadhietala am I doing the a full INUR on the test that need the full treatment.

[chancancode]

We can add a simple curly to the block to make sure it updates:

this.registerComponent('yield-comp', { template: '<div>[In layout] {{yield}}</div>' });

// I
this.render('{{#yield-comp}}[In block: {{foo}}]{{/yield-comp}}', { foo: "foo" });
this.assertText('[In layout] [In block: foo]');

// N
this.assertStableRerender();

// U
this.runTask(() => set(this.context, 'foo', 'bar');
this.assertText('[In layout] [In block: bar]');

// R
this.runTask(() => set(this.context, 'foo', 'foo');
this.assertText('[In layout] [In block: foo]');

[kiwiupover]

@chancancode @chadhietala @krisselden

I have update the first few tests to do a full INUR by adding some curlies at @chancancode promoting. Also I removed all jQuery crap.

The parentView test is the only test not doing a full INUR.

Also I think we need more testing for the yield helper ie {{yield foo}}, {{yield 'title'}} and {{yield this}} to name a few. This PR replaces the HTMLbar test. I can open an issue for more complete {{yield}} tests.

[chancancode]

Thanks @kiwiupover 🎉 🎉 🎉 🎉 🎉