Bump RSVP dependency #12532
Merged
Bump RSVP dependency #12532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good to me. @stefanpenner - Any objections? |
|
(Build is broken on master due to a downstream dep change, not necessarily this PR) |
nope LGTM |
|
Rebased but sauce build still fails, everything else is green |
|
potentially just a random saucelabs error, kicking it. |
|
Looks like, before Edge was failing, now it's IE9 and IE10.. can you kick it again? |
|
@dschmidt kicking Someone should likely add some basic retry (up to two times or something) to the sauce lab tests.. |
|
Everything passed! 👍 |
|
thank you kindly sir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
would be nice to have latest rsvp which adds the
labelas second argument to theon('error', ...)hook.tildeio/rsvp.js#404
BR,
Domme