[BUGFIX beta] Fix stack overflow in wrap. #12132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,6 +39,10 @@ import { | |||
| } from 'ember-metal/events'; | |||
| import { isStream } from 'ember-metal/streams/utils'; | |||
|
|
|||
|
|
|||
| function K(){}; | |||
There was a problem hiding this comment.
Needs a space and no semicolon. Like:
function K() {}
There was a problem hiding this comment.
this should just be called something other then K, ember already has K and it represents the K Combinator, which this does not.
Lets just call it Noop or Root or something.
|
@rwjblue @stefanpenner I addressed the comments, I'd like to add the argument copying back in because I misunderstood some things. The only thing this took care of was needing to prewarm the branches since there is no longer a shared function with branching. |
Fix stack overflow when adding terminating wrapper to superFunc in wrap. For some reason, the recursive call to wrap that doesn’t have an obvious termination, yet wasn’t causing a stack overflow until minified. Something is wrong with our tests that are supposed to run against the minified build.
rwjblue
added a commit
that referenced
this pull request
Aug 18, 2015
[BUGFIX beta] Fix stack overflow in wrap.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix stack overflow when adding terminating wrapper to superFunc in wrap.
For some reason, the recursive call to wrap that doesn’t have an obvious termination, yet wasn’t causing a stack overflow until minified.
Something is wrong with our tests that are supposed to run against the minified build.