Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Properly load deprecateFunc before calling it #11744

Merged
merged 1 commit into from
Jul 15, 2015

Conversation

juggy
Copy link
Contributor

@juggy juggy commented Jul 14, 2015

Solves #11742

@rwjblue
Copy link
Member

rwjblue commented Jul 14, 2015

I would prefer to move the calls to deprecateFunc down to where the others are (around Ember.keys and Ember.create), can you confirm that works and update?

Solves emberjs#11742

Move deprecation to the bottom
@juggy
Copy link
Contributor Author

juggy commented Jul 14, 2015

Moved them to the bottom.

@rwjblue
Copy link
Member

rwjblue commented Jul 14, 2015

This affects current release, right? If so, can you prefix with [BUGFIX release] (sorry for the run around, I should have mentioned this in my last comment)?

@juggy juggy changed the title Properly load deprecateFunc before calling it [BUGFIX release] Properly load deprecateFunc before calling it Jul 14, 2015
rwjblue added a commit that referenced this pull request Jul 15, 2015
[BUGFIX release] Properly load deprecateFunc before calling it
@rwjblue rwjblue merged commit c2196e2 into emberjs:master Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants