Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX release] Return Ember.LinkView.reopen() properly. #11543

Merged
merged 1 commit into from
Jun 24, 2015
Merged

[BUGFIX release] Return Ember.LinkView.reopen() properly. #11543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/ember-routing-views/lib/views/link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,8 @@ var originalReopen = DeprecatedLinkView.reopen;

DeprecatedLinkView.reopen = function reopenWithDeprecation() {
Ember.deprecate('Ember.LinkView is deprecated. Please use Ember.LinkComponent.', false);
originalReopen.apply(this, arguments);

return originalReopen.apply(this, arguments);
};
export { DeprecatedLinkView };
/* DeprecatedLinkView - End*/
Expand Down
3 changes: 2 additions & 1 deletion packages/ember-routing-views/tests/main_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@ QUnit.test("Ember.LinkView throws a deprecation warning when instantiated", func

QUnit.test("Ember.LinkView throws a deprecation warning when reopened", function() {
expectDeprecation(/Ember.LinkView is deprecated. Please use Ember.LinkComponent/);
Ember.LinkView.reopen({});

ok(Ember.LinkView.reopen({}), 'maintains return value');
});