[BUGFIX release] Ensure handleURL called after setURL in visit helper #11317
Conversation
| @@ -59,14 +59,13 @@ function visit(app, url) { | |||
| var router = app.__container__.lookup('router:main'); | |||
| app.boot().then(function() { | |||
| router.location.setURL(url); | |||
| run(app.__deprecatedInstance__, 'handleURL', url); | |||
There was a problem hiding this comment.
Lets tweak this slightly so it only runs in the else case below (via a guard or something). Otherwise, we end up double routing on the first visit call (a default app boot would have transitioned into the initial URL then we call handleURL to transition again).
|
Thank you for tracking down and fixing!! I left a small inline comment/tweak, but should be good to go once that is fixed... |
jaswilli
force-pushed
the
visit-regression
branch
from
2b44d90
to
f869e4b
Compare
|
👍 - LGTM |
|
Updated to prevent the double routing. Thanks for the review and feedback! 😄 |
[BUGFIX release] Ensure handleURL called after setURL in visit helper
|
@rwjblue This never made it into 1.12.x and it's not in 1.13.0 either? Is there a problem or did it just get lost in the shuffle? |
|
It was my mistake :(, I've cherry-picked into stable branch for 1.13.1 release today/tomorrow. I'm very sorry for the oversight. |
There's a regression in 1.12.1 where if you
visit()a URL that has a transition (this.transitionTo()in abeforeModelhook) after already visiting some other URL thathandleURLwon't be invoked with the correct context andcurrentURL()will yield the "pre-transition" URL.Here's a failing jsbin for 1.12.1: http://emberjs.jsbin.com/nafakuz/5/edit
And a working jsbin on 1.11.3: http://emberjs.jsbin.com/tosacu/2/edit