[FEATURE] Add 'autocomplete' to Ember.Select view #10200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there no additional tests needed? Can you make sure this gets squashed to a single commit and gets appropriately tagged. See https://github.com/emberjs/ember.js/blob/master/CONTRIBUTING.md |
|
@trek there are no additional tests needed. Similar HTML 5 attributes also don't have tests. If a test was needed it would only be to verify that attributeBindings is working properly, but that's really outside the scope of this PR. The 2 commits have now been squashed into 1 and tagged appropriately. |
jednano
changed the title
wagenet
added a commit
that referenced
this pull request
Feb 28, 2015
[FEATURE] Add 'autocomplete' to Ember.Select view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would enable Chrome Autofill and similar mechanisms to know what value to select in the select box.