Merge pull request #11512 from stefanpenner/pr-10669-rebase

[Bugfix release] Deprecate Ember.oneWay
emberjs · Jun 19, 2015 · d8b1bb1 · d8b1bb1
2 parents bc7ec8d + e56650d
commit d8b1bb1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 10 deletions.
diff --git a/packages/ember-htmlbars/tests/integration/binding_integration_test.js b/packages/ember-htmlbars/tests/integration/binding_integration_test.js
@@ -166,16 +166,20 @@ QUnit.test('should update bound values after view\'s parent is removed and then
 });
 
 QUnit.test('should accept bindings as a string or an Ember.Binding', function() {
-  var ViewWithBindings = EmberView.extend({
-    oneWayBindingTestBinding: Binding.oneWay('context.direction'),
-    twoWayBindingTestBinding: Binding.from('context.direction'),
-    stringBindingTestBinding: 'context.direction',
-    template: compile(
-      'one way: {{view.oneWayBindingTest}}, ' +
-      'two way: {{view.twoWayBindingTest}}, ' +
-      'string: {{view.stringBindingTest}}'
-    )
-  });
+  var ViewWithBindings;
+
+  expectDeprecation(function() {
+    ViewWithBindings = EmberView.extend({
+      oneWayBindingTestBinding: Binding.oneWay('context.direction'),
+      twoWayBindingTestBinding: Binding.from('context.direction'),
+      stringBindingTestBinding: 'context.direction',
+      template: compile(
+        'one way: {{view.oneWayBindingTest}}, ' +
+        'two way: {{view.twoWayBindingTest}}, ' +
+        'string: {{view.stringBindingTest}}'
+      )
+    });
+  }, 'Ember.oneWay has been deprecated. Please use Ember.computed.oneWay instead.');
 
   view = EmberView.create({
     viewWithBindingsClass: ViewWithBindings,

diff --git a/packages/ember-metal/lib/binding.js b/packages/ember-metal/lib/binding.js
@@ -333,6 +333,7 @@ mixinProperties(Binding, {
     @public
   */
   oneWay(from, flag) {
+    Ember.deprecate('Ember.oneWay has been deprecated. Please use Ember.computed.oneWay instead.', false);
     var C = this;
     return new C(undefined, from).oneWay(flag);
   }