Make sure initializers can modify the DOM #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initializers were running after the snapshot of the root element was taken, meaning that if an initializer modified the contents of the root element, that modification would not persist beyond the first test. So we boot the app a little earlier to make sure initializers can safely modify the DOM.
rwjblue
approved these changes
Jan 26, 2018
|
Thank you! |
|
You bet! I'm really liking this new test API, and happy to help out with it when I can! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initializers were running after the snapshot of the root element was taken, meaning that if an initializer modified the contents of the root element, that modification would not persist beyond the first test. So we boot the app a little earlier to make sure initializers can safely modify the DOM.