Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support testing without an application template wrapper. #305

Merged
merged 11 commits into from
Feb 10, 2018
Merged

Support testing without an application template wrapper. #305

merged 11 commits into from
Feb 10, 2018

Commits on Feb 10, 2018

  1. Support apps with Feature Flag ember-glimmer-remove-application-templ… 

    …ate-wrapper enabled
    @cibernox @rwjblue
    cibernox authored and rwjblue committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    b33e608 View commit details
    Browse the repository at this point in the history

  2. Apply last feedback

    @cibernox @rwjblue
    cibernox authored and rwjblue committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    008a507 View commit details
    Browse the repository at this point in the history

  3. Use official mechanism for feature testing.

    @rwjblue
    rwjblue committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    cf11a35 View commit details
    Browse the repository at this point in the history

  4. Remove extra assertions which require wrapper application template.

    @rwjblue
    rwjblue committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    6108cc3 View commit details
    Browse the repository at this point in the history

  5. Correct yarn version (use 3.0.0-beta series).

    @rwjblue
    rwjblue committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    b2708fa View commit details
    Browse the repository at this point in the history

  6. Fix moduleForComponent with missing template wrapper.

    @rwjblue
    rwjblue committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    7d0b188 View commit details
    Browse the repository at this point in the history

  7. Use explicit check for checking for application template wrapper.

    @rwjblue
    rwjblue committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    71d0ec0 View commit details
    Browse the repository at this point in the history

  8. Cleanup linting enable/disable for EmberENV.

    @rwjblue
    rwjblue committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    cce1782 View commit details
    Browse the repository at this point in the history

  9. Simplify naming of without application wrapper scenario. 

    Ultimately, this will become part of released Ember versions so no
reason to keep `canary` in the name.
    @rwjblue
    rwjblue committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    7af8ea2 View commit details
    Browse the repository at this point in the history

  10. Test clicking "wormholed" content with and without wrapper div.

    @rwjblue
    rwjblue committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    df741fb View commit details
    Browse the repository at this point in the history

  11. Ensure tests exist for where this.element goes.

    @rwjblue
    rwjblue committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    a16b9d3 View commit details
    Browse the repository at this point in the history