Refactor settled to leverage waitUntil. #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I didn't update documentation mostly because exactly how we wait seems like an implementation detail and not really the actual API... |
Turbo87
reviewed
Dec 30, 2017
| }); | ||
| return waitUntil( | ||
| () => { | ||
| return isSettled(options); |
There was a problem hiding this comment.
this could use shorthand arrow function syntax to simplify the code
There was a problem hiding this comment.
Yep, sounds good. Will update.
|
|
||
| import { nextTick } from './-utils'; | ||
| const TIMEOUTS = [0, 1, 2, 5, 7]; |
There was a problem hiding this comment.
Yeah, I added another entry. Does It seem bad?
Migrates ramp up functionality to `waitUntil` and migrates `settled` to leverage `waitUntil`.
rwjblue
force-pushed
the
refactor-wait-until
branch
from
1c9a169
to
db300fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates ramp up functionality to
waitUntiland migratessettledto leveragewaitUntil.