Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Make valid-jsdoc an error (instead of warning) #290

Merged
merged 2 commits into from
Dec 29, 2017

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Dec 29, 2017

Now that the documentation is updated, this makes it an error...

@Turbo87
Copy link
Member

Turbo87 commented Dec 29, 2017

FWIW documentation also has a lint command 🤔

@rwjblue
Copy link
Member Author

rwjblue commented Dec 29, 2017

Hmm, what does it do?

@rwjblue
Copy link
Member Author

rwjblue commented Dec 29, 2017

I'll add a lint script for it and add it to the initial linting build...

@Turbo87
Copy link
Member

Turbo87 commented Dec 29, 2017

I think it does something similar, just not sure why they recommend the ESLint rule in their docs... using both can't hurt though

@rwjblue rwjblue merged commit f25ad0f into emberjs:master Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants