Expose settled helper function.
#223
Conversation
* Rename `wait` to `settled`
* Ensure existing `import wait from 'ember-test-helpers/wait'` code works properly
* Export `settled` as public API from the main `index.js`
* Move existing `wait` tests into `legacy-0-6-x` folder
Primary reasoning for the rename from `wait` to `settled`:
```js
test('can do xyz', async function(assert) {
await this.render(hbs`{{some-thing}}`);
await click('.some-thing');
await wait(); // <- WAT?!?!!?
});
```
This looks much better:
```js
test('can do xyz', async function(assert) {
await this.render(hbs`{{some-thing}}`);
await click('.some-thing');
await settled();
});
```
rwjblue
force-pushed
the
migrate-wait-to-settled
branch
from
913c171 to
568600c
Compare
rwjblue
force-pushed
the
migrate-wait-to-settled
branch
from
568600c to
4d9d28a
Compare
addon-test-support/settled.js
Outdated
| let waitForWaiters = options.hasOwnProperty('waitForWaiters') ? options.waitForWaiters : true; | ||
|
|
||
| return new EmberPromise(function(resolve) { | ||
| let watcher = self.setInterval(function() { |
There was a problem hiding this comment.
should this use the new ./global util instead of self?
There was a problem hiding this comment.
Definitely, will update.
| _setupPromiseListeners, | ||
| _teardownAJAXHooks, | ||
| _teardownPromiseListeners, | ||
| } from './settled'; |
There was a problem hiding this comment.
this is fine for now, I'm just wondering if we should deprecate importing this module at some point?
There was a problem hiding this comment.
Ya, totally agreed. Basically, I want to introduce all the new functionality without deprecating anything at first. Then as we get more sure of the new system (e.g. after a little while of using the new API’s by default) we add in all the deprecations.
I want to be very careful about deprecation spew leading in to Ember 3.0...
| }); | ||
|
|
||
| test('it waits for Ember test waiters', async function(assert) { | ||
| await this.render(hbs`{{x-test-5}}`); |
There was a problem hiding this comment.
since render() without this is apparently meant to be the documented default should we use it here too?
There was a problem hiding this comment.
Ya, but I didn’t want to do that here since I wasn’t sure how you felt about the other PR yet.
2 participants
waittosettledimport wait from 'ember-test-helpers/wait'code works properlysettledas public API from the mainindex.js.waittests intolegacy-0-6-xfolderwaittests to the new API style (setupRenderingContext, async/await, etc)The primary reasoning for the rename from
waittosettled:This looks much better: