Refactor moduleForComponent rendering to use outlet system.
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting `context` or `controller` on an `Ember.Component` was absolutely not supposed to work (ever), but this library worked around that to serve its own needs when `Ember.View` was deprecated and removed. This PR makes `moduleForComponent` work properly against canary (soon to be 2.7.0), by avoiding this archaic concept and simply tracking the things `set` on the test context manually.
|
|
||
| context.setProperties = function(hash) { | ||
| var ret = Ember.run(function() { | ||
| return Ember.setProperties(context, hash); |
There was a problem hiding this comment.
Only in Ember 2.0+, it is intended to emulate what Ember.setProperties does: https://github.com/emberjs/ember.js/blob/dc4b60be5849a6dad2cc464822294a435e08e31c/packages/ember-metal/lib/set_properties.js#L37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting context or controller on an Ember.Component was absolutely not supposed to work (ever), but this library worked around that to serve its own needs when Ember.View was deprecated and removed.
This PR makes
moduleForComponentwork properly against canary (soon to be 2.7.0), by avoiding this archaic concept and using normal outlet system.