Ensure typeIn has correct key option

emberjs · Nov 7, 2018 · 8d7c65a · 8d7c65a
1 parent a6aae8a
commit 8d7c65a
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/addon-test-support/@ember/test-helpers/dom/type-in.ts b/addon-test-support/@ember/test-helpers/dom/type-in.ts
@@ -67,6 +67,7 @@ function keyEntry(element, character) {
     bubbles: true,
     cancellable: true,
     charCode,
+    key: character,
   };
 
   const keyEvents = {

diff --git a/tests/unit/dom/type-in-test.js b/tests/unit/dom/type-in-test.js
@@ -77,6 +77,25 @@ module('DOM Helper: typeIn', function(hooks) {
     assert.equal(element.value, 'foo');
   });
 
+  test('it triggers key events with correct arguments', async function(assert) {
+    element = buildInstrumentedElement('input', ['key', 'charCode']);
+    await typeIn(element, 'foo');
+
+    let chars = ['f', 'o', 'o'];
+    let expectedEventsWithArguments = expectedEvents.map(eventName => {
+      // Only key events get the key arguments
+      if (!['keydown', 'keypress', 'keyup'].includes(eventName)) {
+        return `${eventName} undefined undefined`;
+      }
+      // After each keyup, the next character comes up
+      let char = eventName === 'keyup' ? chars.shift() : chars[0];
+
+      return `${eventName} ${char} ${char.charCodeAt()}`;
+    });
+
+    assert.verifySteps(expectedEventsWithArguments);
+  });
+
   test('filling in an input with a delay', async function(assert) {
     element = buildInstrumentedElement('input');
     await typeIn(element, 'foo', { delay: 150 });