Add support for Component.$() as part of RFC386 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonihmig
commented
Jan 9, 2019
simonihmig
force-pushed
the
component.dollar
branch
from
ddfcfc6 to
e017d85
Compare
This was referenced Jan 12, 2019
simonihmig
force-pushed
the
component.dollar
branch
from
e017d85 to
2f5bb77
Compare
simonihmig
changed the title
Contributor
Author
|
@rwjblue this is ready for review now:
|
rwjblue
requested changes
Jan 23, 2019
rwjblue
reviewed
Jan 23, 2019
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
One minor nit, but looks good otherwise...
vendor/jquery/component.dollar.js
Outdated
| (function() { | ||
| Ember.Component.reopen({ | ||
| $(sel) { | ||
| Ember.assert( |
Member
There was a problem hiding this comment.
Now that I think about it, I think we do need to use:
import { assert } from '@ember/debug';to get the proper stripping...
IMHO, this is safe (even when we move Ember to real modules, we would still handle this specially).
Contributor
Author
There was a problem hiding this comment.
Oh, good catch! Updated this.
Before:
After:
simonihmig
force-pushed
the
component.dollar
branch
from
fd8cfcb to
c1e640c
Compare
rwjblue
approved these changes
Jan 23, 2019
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.