Skip to content

Conversation

@patricklx
Copy link
Collaborator

@patricklx patricklx commented Jun 26, 2023

with this we can drop the resolution-highest in the npmrc file and have even faster installs & tests (well, 1-2sec)

Description

Screenshots

with this we can drop the npmrc file and have even faster installs & tests
@RobbieTheWagner
Copy link
Member

How does this help us? Is this something new ember-try is going to be doing going forward?

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Jul 15, 2023

Ember try will now be using --no-lockfile, introduced in: ember-cli/ember-try#960

And without a lockfile, i believe it chooses the highest deps available, if in range ones aren't in the store
(You may still want resolution-highest for control over the behavior though)

The key thing is that the package.json is the source of truth, and pnpm will normally take the shortest path to satisfying the package.json.

If you want the latest deps always, the package.json should reflect that.

Using the lower versions helps testing maximum compatibility for library authors.

@patricklx
Copy link
Collaborator Author

Lets leave it as it is then. As this is also not a library.

@patricklx patricklx closed this Jul 15, 2023
@patricklx patricklx deleted the patch-4 branch July 16, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants