Skip to content

Conversation

@locks
Copy link
Contributor

@locks locks commented Jan 9, 2019

When running the tests for @ember/string, ember-cli-babel does not detect it properly and tries to process the imports for that module, leading to a failed test run.

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. Isn't the fix needed here to actually tweak _emberStringDependencyPresent to be something like:

_emberStringDependencyPresent() {
  if (this.project.name() === '@ember/string') {
    return true;
  }

  let checker = new VersionChecker(this.parent).for('@ember/string', 'npm');	    
  return checker.exists();
},

@locks
Copy link
Contributor Author

locks commented Jan 15, 2019

@rwjblue 🤦‍♂️ updated.

@locks locks mentioned this pull request Jan 15, 2019
1 task
@locks locks changed the title Add emberModulesAPIPolyfillBlacklist options so ember string can exclude itself Update @ember/string detection to check if it is the project being run Jan 15, 2019
@rwjblue rwjblue merged commit 014852a into emberjs:master Jan 18, 2019
@rwjblue rwjblue added the bug label Jan 22, 2019
@rwjblue rwjblue changed the title Update @ember/string detection to check if it is the project being run Update @ember/string detection to work on itself Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants